Opened 8 years ago

Closed 8 years ago

#282 closed enhancement (fixed)

HTTP Authentication

Reported by: jeffstieler Owned by: jb6262
Priority: major Milestone: 2.1
Component: XML-RPC Version: 2.0
Keywords: has-patch Cc: chrisscott, prettyboymp

Description

Added "HTTP Authentication" menu option when creating/editing a blog, as well as code to support it.

Allows user to enter credentials to use to satisfy basic HTTP authentication, used in blog validation and XML-RPC calls.

Attachments (8)

XMLRPCConnection+Authentication.h (410 bytes) - added by jeffstieler 8 years ago.
NSData+Base64.h (847 bytes) - added by jeffstieler 8 years ago.
NSData+Base64.m (7.9 KB) - added by jeffstieler 8 years ago.
XMLRPCConnection+Authentication.m (2.7 KB) - added by jeffstieler 8 years ago.
282.patch (53.1 KB) - added by jeffstieler 8 years ago.
BlogHTTPAuthenticationViewController.h (1.1 KB) - added by jeffstieler 8 years ago.
BlogHTTPAuthenticationViewController.m (2.1 KB) - added by jeffstieler 8 years ago.
BlogHTTPAuthenticationViewController.xib (31.0 KB) - added by jeffstieler 8 years ago.

Download all attachments as: .zip

Change History (24)

comment:1 Changed 8 years ago by chrisscott

  • Cc chrisscott added

comment:2 Changed 8 years ago by prettyboymp

  • Cc prettyboymp added

comment:3 Changed 8 years ago by iammattthomas

  • Owner set to jb6262
  • Status changed from new to assigned

Thanks for the patch, Jeff. The build failed though; it looks like I'm missing the following files. Can you attach them to this ticket?

BlogHTTPAuthenticationViewController.xib
BlogHTTPAuthenticationViewController.h
XMLRPCConnection+Authentication.h
NSData+Base64.h

Changed 8 years ago by jeffstieler

Changed 8 years ago by jeffstieler

comment:4 Changed 8 years ago by jeffstieler

All set, let me know if I forgot anything else! D'oh!

Changed 8 years ago by jeffstieler

Changed 8 years ago by jeffstieler

comment:5 Changed 8 years ago by jb6262

Hey - thanks Jeff! I'll look at this asap...

comment:6 Changed 8 years ago by iammattthomas

Thanks, Jeff! I've got it built and it's working well. I've got a couple of small usability requests:

  • The "Next" button to tab between the username and password fields doesn't work
  • If I enter a HTTP auth user/pass, but don't tap the "On" toggle, my info isn't saved. Could we disable the text inputs until they've switched it on, to avoid losing the credentials and having to retype?
  • After I've entered my HTTP auth password, I just tap the back button to save it. That works well, but it felt a little disconcerting to go back while the password field was still focused and the keyboard was still up. A blue "Done" button in place of "Next" there that puts away the keyboard would help reassure the user that their info has been entered successfully.

comment:7 Changed 8 years ago by jeffstieler

I'll work on these issues now, and upload a new patch when finished.

comment:8 Changed 8 years ago by iammattthomas

  • Milestone changed from 2.0.2 to 2.0.1

comment:9 Changed 8 years ago by jeffstieler

Is it ok to just have the auth user/pass _always_ persist, and then get used only if the switch is "on" ?

comment:10 Changed 8 years ago by jb6262

Do you mean is it OK to keep auth username and password in the keychain permanently and then only use them when the switch is on?

If so, yes - I think that should be fine...

comment:11 Changed 8 years ago by jeffstieler

All set!

comment:12 Changed 8 years ago by iammattthomas

Thanks Jeff! All the changes look good.

There's still one small issue -- after I've entered my HTTP Authentication information and turned it on, if I return to the Blog Settings screen, then tap on HTTP Authentication again, the setting reverts to off and my username and password are cleared.

comment:13 Changed 8 years ago by jeffstieler

I have this resolved. Give me a few minutes to clean up the code and submit patch/files.

Changed 8 years ago by jeffstieler

Changed 8 years ago by jeffstieler

Changed 8 years ago by jeffstieler

Changed 8 years ago by jeffstieler

comment:14 Changed 8 years ago by jeffstieler

All uploaded, please disregard the BlogDataManager .h/m and EditBlogViewController.h (delete please!)

comment:15 Changed 8 years ago by iammattthomas

Committed in r674. Thanks for your help, jeff!

comment:16 Changed 8 years ago by iammattthomas

  • Resolution set to fixed
  • Status changed from assigned to closed
Note: See TracTickets for help on using tickets.