Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#1528 closed defect (fixed)

Jetpack stats don't work for multisite blogs

Reported by: koke Owned by: aerych
Priority: major Milestone: 3.4
Component: Statistics Version: 3.3
Keywords: Cc: aerych


It seems multisite blogs don't authenticate properly. I get a "You're not a member of this site" message.

It seems related to a (blogID==1) check on initStats, but the underlying problem is replacing blogID with the blog ID

Change History (7)

comment:1 Changed 5 years ago by koke

This only happens if you tap "Save" on the jetpack settings screen, instead of "Verify and Save Credentials"

comment:2 Changed 5 years ago by koke

I think we should require Jetpack 1.9 and rely on jetpack_client_id and not mess with blogID

comment:3 Changed 5 years ago by aerych

blogID == 1 was a bad way to check for a .com blog. I thought all of those checks had been cleaned up but maybe I missed one or forgot.

+1 for using jetpack_client_id now that we have it.

comment:4 Changed 5 years ago by aerych

  • Owner set to aerych
  • Status changed from new to assigned

comment:5 Changed 5 years ago by aerych

Along with this, I think we should change the Jetpack settings screen.
It looks like options for jetpack_version and jetpack_client_id were introduced in version 1.8.2, so let's make this the lowest supported version for stats. Let's omit the credential fields and just show the install and info buttons when these options are missing.

comment:6 Changed 5 years ago by aerych

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [3778]) Fixes #1528. Always uses jetpack_client_id instead of recycling blogID for .org blogs.
Jetpack 1.8.2 or better is required for stats.
Settings screen does not show credentails when Jetpack needs to be installed or upgraded.

comment:7 Changed 5 years ago by beaucollins

  • Milestone changed from Future Release to 3.4
Note: See TracTickets for help on using tickets.