Opened 2 years ago

Closed 2 years ago

#605 closed defect (fixed but pending verification)

Image Uploader upscales images added from library that are smaller than default device size

Reported by: isaackeyet Owned by: daniloercoli
Priority: blocker Milestone: 2.6.5
Component: Media Version:
Keywords: Cc: daniloercoli

Description

If you upload a screenshot for instance, it's scaled up to the default size of an image taken on the device. Original should always just look at the pictures' original constraints and use that if Original is selected.

If the image is, say 200px wide, and someone picks Large (which is wider), we should either not upscale and just use 200px as it's as wide as it gets, OR .. and this is a better approach .. just disabling the Large button. This is what happens in wp-admin I believe.

For Custom, image size should never be allowed to be bigger than the size of the original image.

Change History (3)

comment:1 Changed 2 years ago by isaackeyet

  • Summary changed from Image Uploader upscales smaller images that are smaller than default device size to Image Uploader upscales images added from library that are smaller than default device size

comment:2 Changed 2 years ago by daniloercoli

  • Owner changed from frsh to daniloercoli
  • Status changed from new to assigned

comment:3 Changed 2 years ago by daniloercoli

  • Cc daniloercoli added
  • Resolution set to fixed but pending verification
  • Status changed from assigned to closed

fixed in [1371].

  • "Original" dimension is now equals to the pictures' original constraints.
  • Disabled the Large/medium/small buttons if the image is small than the defined dimensions.
  • added a check on the Custom image size skipping dimension that is bigger than the size of the original image.

We should check this fix using real devices and images with different orientation and size.

Note: See TracTickets for help on using tickets.