Opened 19 months ago

Closed 9 months ago

Last modified 9 months ago

#1527 closed enhancement (duplicate)

Media settings

Reported by: isaackeyet Owned by: koke
Priority: major Milestone: Future Release
Component: Media Version:
Keywords: Cc: isaackeyet, irbrad

Description

Media settings should be added for uploaded content and should mimic the Android app in layout, wording, and features (where it makes sense).

New view should replace or build upon the image detail view in the attachments section of the Post Editor and retain current functionality.

Proposed content:

  • Image thumbnail (tap to enlarge would be a bonus). Should mimic the layout of Featured Images in the Post Editor / Settings section.
  • Caption field
  • Link to... setting (mimic core). To start with the only options could be "No linking" and "Media File" but in the future we may want to do "Custom URL" and "Attachment Page" as well.
  • Alignment section with 4 settings: None (default), Left, Center, Right.
  • Positioning: Above Content, Below Content (retaining current functionality but with an improved UI).
  • Width: a regular input field coupled with a slider to change the px value (see the Android app for a good implementation of the slider). We may also want to show a greyed out height value somewhere in the UI but not necessary. See Android app for implementation details.
  • Large, red Remove Image button with actionSheet to confirm the action towards the bottom (retaining current functionality).

All new features would be reflected in the markup for the image embedded in the post editor and we also need to make sure it works well with images embedded by other apps and by WP itself.

See attached wireframe for a rough idea of what the view could look like.

Attachments (8)

Screen Shot 2013-01-05 at 12.31.49 AM.png (43.0 KB) - added by isaackeyet 19 months ago.
iPad media settings.png (240.4 KB) - added by jkv1 19 months ago.
iPad media settings UI
iPad media settings option selection.png (182.2 KB) - added by jkv1 19 months ago.
iPad media settings option selection UI
iPhone media settings.png (93.7 KB) - added by jkv1 19 months ago.
iPhone media settings UI
1515-media-settings-for-images.diff (672.5 KB) - added by jkv1 19 months ago.
media-settings-for-images-no-binary.diff (666.6 KB) - added by jkv1 19 months ago.
button_red.png (2.3 KB) - added by jkv1 19 months ago.
button_red@2x.png (3.4 KB) - added by jkv1 19 months ago.

Download all attachments as: .zip

Change History (18)

Changed 19 months ago by isaackeyet

comment:1 Changed 19 months ago by jkv1

  • Owner set to jkv1
  • Status changed from new to assigned

comment:2 Changed 19 months ago by isaackeyet

  • Cc isaackeyet irbrad added

Changed 19 months ago by jkv1

iPad media settings UI

Changed 19 months ago by jkv1

iPad media settings option selection UI

Changed 19 months ago by jkv1

iPhone media settings UI

Changed 19 months ago by jkv1

comment:3 Changed 19 months ago by jkv1

Attached a file: 1515-media-settings-for-images.diff

For images uploaded from the application there is a new screen shown that allows the user to set the caption, alignment, positioning, custom width and remove the image. A sample of the HTML generated is:

[caption align="aligncenter" width="250"]<a href="http://someurl.com/image.jpg"><img src="http://someurl.com/image.jpg" width="250" /></a>My caption[/caption]

If the user does not have a caption set the HTML would be:

<a href="http://someurl.com/image.jpg"><img src="http://someurl.com/image.jpg" width="250" class="aligncenter"/></a>	

The post HTML manipulation is still very poor in that it is just doing a string replace for the old HTML to the new media settings so the same problems exist where if a user makes any changes to the image HTML then the media settings changes will end up creating duplicate image HTML.

The core data version was increased so that the media table would contain caption, alignment, and custom width and height.

The "Image thumbnail (tap to enlarge would be a bonus)" will be trivial to add once #1515 is merged into SVN

comment:4 Changed 19 months ago by jkv1

  • Owner changed from jkv1 to isaackeyet

comment:5 Changed 19 months ago by jkv1

  • Resolution set to fixed
  • Status changed from assigned to closed

comment:6 Changed 19 months ago by koke

I'm getting an error:

patching file WordPress.xcodeproj/project.pbxproj
patching file button_red.png
patch: **** malformed patch at line 112: \ No newline at end of file

Can you try attaching binary files separate, or maybe a pull request on github?

Changed 19 months ago by jkv1

Changed 19 months ago by jkv1

comment:7 Changed 19 months ago by jkv1

  • Resolution fixed deleted
  • Status changed from closed to reopened

I don't think I should have closed this issue until after the patch is accepted on github. I'm going to assign to koke since I think he is the one reviewing it.

https://github.com/wordpress-mobile/WordPress-iOS/pull/10

comment:8 Changed 19 months ago by jkv1

  • Owner changed from isaackeyet to koke
  • Status changed from reopened to assigned

comment:9 Changed 9 months ago by sendhil

  • Resolution set to duplicate
  • Status changed from assigned to closed
Note: See TracTickets for help on using tickets.